Created an EventLog object for Utils#223
Merged
Merged
Conversation
…ade fields public
navyacodes
requested review from
a team,
Jannetty,
afu5,
allison-li-1016,
cainja,
daniellevahdat,
jacob-evarts and
jessicasyu
and removed request for
a team
navyacodes
added
priority: medium
allison-li-1016
approved these changes
May 15, 2026
Contributor
allison-li-1016
left a comment
allison-li-1016
left a comment
There was a problem hiding this comment.
This looks good to me! Sorry it took so long!
Jannetty
reviewed
May 18, 2026
Jannetty
approved these changes
May 18, 2026
Member
Jannetty
left a comment
Jannetty
left a comment
There was a problem hiding this comment.
Please fix the spelling error in ProliferationEventLog. You can also consider shortening docstrings for the eventDetails() functions in the concrete EventLog classes as the map contents are clear from the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimated time to review: small
Summary of changes:
EventLogabstract class to Utils to standardize representation of simulation eventsLysisEventLogfor logging CD8 CAR T-cell lysis events, and removed previous event log creation inPatchModuleCytotoxicityProliferationEventLogfor logging cell proliferation events, and removed previous event log creation inPatchModuleProliferationeventDetailsmethod to create the map worked as expected)Resolves #216