Skip to content

✅ Allow home query parameters in E2E#255

Merged
baealex merged 1 commit into
mainfrom
fix/e2e-home-url-assertion
Jul 11, 2026
Merged

✅ Allow home query parameters in E2E#255
baealex merged 1 commit into
mainfrom
fix/e2e-home-url-assertion

Conversation

@baealex

@baealex baealex commented Jul 11, 2026

Copy link
Copy Markdown
Owner

🎯 Goal

  • Restore reliable release E2E validation after the home route began normalizing default search parameters.
  • Keep the login test focused on reaching the authenticated home route rather than an exact query string.

🛠️ Core Changes

  • Assert the authenticated URL pathname is /.
  • Allow the router to append its canonical default home search parameters.

🧠 Key Decisions

  • Kept the assertion strict about the destination path.
  • Did not change runtime routing or login behavior.
  • Release impact: release: no-impact.

🧪 Verification Guide

How to verify

  1. Run pnpm check:encoding.
  2. Run pnpm lint.
  3. Run pnpm type-check.
  4. Run pnpm build.
  5. Run pnpm test:e2e.

Expected result

  • All commands pass.
  • The authenticated browser reaches the / pathname.
  • Canonical home query parameters do not fail the login E2E test.

✅ Checklist

  • Encoding check completed
  • Lint completed
  • Type-check completed
  • Build completed
  • E2E completed
  • Release impact label applied: release: no-impact

@baealex baealex added the release: no-impact No released artifact or user-visible release impact label Jul 11, 2026
@baealex baealex merged commit 5b5c4d3 into main Jul 11, 2026
6 checks passed
@baealex baealex deleted the fix/e2e-home-url-assertion branch July 11, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: no-impact No released artifact or user-visible release impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant