Skip to content

docs: update documentation#115

Merged
JellyBellyDev merged 8 commits into
badges:masterfrom
jmleroux:docker-doc
Jan 7, 2026
Merged

docs: update documentation#115
JellyBellyDev merged 8 commits into
badges:masterfrom
jmleroux:docker-doc

Conversation

@jmleroux

Copy link
Copy Markdown
Contributor
  • Update documentation about Docker usage for dev
  • Introduce Makefile instead of Composer scripts. I believe this is the most widespread practice in the Symfony ecosystem.
  • Update README with some generated images
  • Mutualize Docker compose configuration

@jmleroux jmleroux marked this pull request as ready for review October 27, 2025 10:33
Comment thread Makefile Outdated
Comment thread README.md
Comment thread .github/workflows/php.yml
- name: Run tests
run: CONTAINER=${{ matrix.container }} make tests

tests-php84:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted from the matrix while it is not stable

Comment thread .github/workflows/php.yml
@jmleroux

Copy link
Copy Markdown
Contributor Author

See kartsims/easysvg#39 for an EasySVG fix for PHP 8.4

@garak garak added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com/ label Oct 31, 2025
@jmleroux

jmleroux commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

See kartsims/easysvg#39 for an EasySVG fix for PHP 8.4

I'try to have some news about the fix.

@garak

garak commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

See kartsims/easysvg#39 for an EasySVG fix for PHP 8.4

I'try to have some news about the fix.

From what I see in the linked issue, there's only a deprecation.
That should not prevent us from using EasySVG on PHP 8.4 (or on PHP 8.5, either)

Comment thread .github/workflows/php.yml Outdated
run: |
docker compose run --rm php84 bin/php-cs-fixer fix --verbose --diff --dry-run
docker compose run --rm php84 bin/phpunit
docker compose run --rm php84 php -d error_reporting='E_ALL & ~E_DEPRECATED' bin/behat --snippets-for

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could also hide deprecation for all tests. But it's like hiding the dust under the carpet.
Thoughts?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding all deprecations for php 8.4 is acceptable for me. We can still remove the hiding later, when hopefully easysvg will have solved its problems.

@jmleroux

jmleroux commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

Last commit is a demo with deprecation ignored for all behat tests.
It can be reverted if needed.

@JellyBellyDev

Copy link
Copy Markdown
Collaborator

LGTM 👍

@JellyBellyDev JellyBellyDev merged commit 469454e into badges:master Jan 7, 2026
6 checks passed
@jmleroux

jmleroux commented Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted https://hacktoberfest.digitalocean.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants