feat: !leader uses server display names, no longer pings#62
Merged
Conversation
Reactions leaderboard previously embedded `<@id>` mention tokens, which ping the user every time the command runs. Render server display names as plain text instead, and clamp allowedMentions so a name containing literal "@everyone" can't ping either. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
badLlama121
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
!leadernow renders each ranked user's server display name (nickname → global display name → username) as plain text, instead of embedding<@id>mention tokens.Why
The old format embedded
<@id>mentions, which pinged every listed user every time the command ran. This makes the leaderboard quiet.How
reactions.js—getLeaderboardnow takes aresolveName(userId)callback (sync or async) and is itselfasync.index.js— the!leaderhandler resolves IDs viaguild.members.fetch(id).displayName, falling back to"unknown user", and sends withallowedMentions: { parse: [] }as a safety belt against literal@everyonein a name.🤖 Generated with Claude Code