Fix three !s command bugs#54
Merged
Merged
Conversation
- Split on first / only so search phrases containing / (e.g. AC/DC) work correctly - Guard isBlockedSearchPhrase against undefined replacement to prevent crash when no / is used - Fix message skip filter to use === 0 so only !s commands are skipped, not any message containing !s Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
zippy1981
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/only — search phrases containing/(e.g.!s AC/DC/something) previously parsed as search=AC, replace=DC; now correctly usesAC/DCas the searchundefinedreplacement crash —!s phrasewith no/would throw aTypeErrorinisBlockedSearchPhrasewhenSEARCH_PHRASES_TO_BLOCKis configuredindexOf('!s') > -1to=== 0so only messages that start with!sare excluded from search history, not any message that happens to contain those charactersTest plan
!s AC/DC/somethingshould search forAC/DC!s phrasewith no slash should not crash!smid-sentence should now be searchable🤖 Generated with Claude Code