Skip to content

Issue #34: Fix fatal error with text fields as of Backdrop 1.33.0 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elisseck merged 2 commits into from
Feb 19, 2026
Merged

Issue #34: Fix fatal error with text fields as of Backdrop 1.33.0 #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443e82e
Issue #34: Fix fatal error with text fields as of Backdrop 1.33.0
indigoxela Jan 18, 2026
9605646
Also use instance in second check
indigoxela Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions field_collection.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ function field_collection_item_is_empty(FieldCollectionItemEntity $item) {
// If at least one collection-field is not empty; the
// field collection item is not empty.
foreach ($item->{$field_name}[$langcode] as $field_item) {
if (!module_invoke($field['module'], 'field_is_empty', $field_item, $field)) {
if (!module_invoke($field['module'], 'field_is_empty', $field_item, $field, $instance)) {
$is_empty = FALSE;
}
}
Expand Down Expand Up @@ -1804,7 +1804,8 @@ function field_collection_field_widget_embed_validate($element, &$form_state, $c
$field_values = reset($field_values);
}

$is_empty_field = module_invoke($field['module'], 'field_is_empty', $field_values, $field);
$instance = field_widget_instance($element, $form_state);
$is_empty_field = module_invoke($field['module'], 'field_is_empty', $field_values, $field, $instance);
}

if ($is_empty_multiple || $is_empty_string || $is_empty_value || $is_empty_option || $is_empty_field) {
Expand Down