Skip to content

Prevent tweak store downgrades and dedupe sidebar logs - #978

Draft
probmetrics wants to merge 1 commit into
b-nnett:mainfrom
probmetrics:agent/settings-store-safety
Draft

Prevent tweak store downgrades and dedupe sidebar logs#978
probmetrics wants to merge 1 commit into
b-nnett:mainfrom
probmetrics:agent/settings-store-safety

Conversation

@probmetrics

Copy link
Copy Markdown

What

  • Log a missing settings sidebar once per absence period.
  • Treat a Store version as an update only when it is strictly newer.
  • Label a locally newer tweak with the Store-approved version instead of calling the older version latest.

Why

Repeated DOM probes can flood the preload log while the settings sidebar is absent. Version inequality also lets an older Store-pinned version appear as an update and downgrade a newer local install.

Impact

The settings log stays useful, and the Store no longer offers version downgrades. Malformed versions are handled conservatively.

Checks

  • npm test (144 passing)
  • npm run build
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant