Fix Windows Store desktop executable detection - #955
Draft
spencerby28 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatGPT.exewhen selecting the Windows desktop application executable.Codex.exefallback for older installations.Codex.exe.Context
The current Windows Store package still uses the
OpenAI.Codexpackage identity, but its application entry point isapp/ChatGPT.exe. The same directory can also contain a smaller helper namedCodex.exe. Existing discovery selects the first executable whose name containsCodex, so generated Codex++ launchers can target the helper and exit without opening the desktop app.This PR is intentionally narrow: it fixes Windows launcher executable selection only. It is unrelated to the in-app browser crash, and it does not attempt the broader cross-platform Codex-to-ChatGPT desktop-app migration.
Validation
tsc -p packages/installer/tsconfig.json --noEmitpasses.