Add dark theme

[stoivo]

closes #26

[stoivo]

As you can see I am not a pro designer but it looks better then the bright one to me.

Do you want me to add a screenshot to README.md?

[stoivo]

ping

[stoivo]

@aziz @kl0tl

[FichteFoll]

Please darken the red background on the file name a bit. Otherwise this does the job.

[aziz]

I don't like the colors, I'm not gonna merge this. make something more decent based on one of the popular dark themes and I'll merge it

[stoivo]

This took too much time.
Is this good?

My preferred theme is Tubnil.

[stoivo]

Thoughts?

[stoivo]

@nivir, any thoughts?

[nivir]

@stoivo personally I never like the dark background and red color, not sure what you can improve. For me I am happy as it is now with Mac Classic.tmTheme :)

[stoivo]

[FichteFoll]

Since I'm also a tubnil user, purple and pink are perfectly fine for me. I also considered the red to be too offensive and distracting before.

[stoivo]

I agree, it was too offensive.

[stoivo]

ping

[stoivo]

pong @aziz @FichteFoll

[stoivo]

I am tired of waiting, any feedback is better than this...

[FichteFoll]

Not my repo, but I mentioned earlier that I like the latest iteration of this.

Generally, it would seem better to have the custom syntax definition use some of the standardized scope names instead of having to bundle custom color schemes, but this would need some exploration. Having a bright and dark scheme should work as a band-aid.

[stoivo]

@aziz hello

[stoivo]

ping @aziz

[FichteFoll]

Ideally the custom syntax would just use normal scope names and region.<color>ish scopes for emphasis of specific areas if needed. That way no scheme overrides are necessary and it will work on every scheme, bright or dark.

[stoivo]

@FichteFoll, I might take a look at that. If/when I get the time.

[Koolstr]

Honestly, why has this still not been implemented? The hard work was already taken care of. At least implement this temporary workaround. Such a crucial plugin needs better styling.

Why can't this plugin simply leave the styling to the app's default, basically matching the user's currently applied Sublime Text theme? That could happen by not including any styling, or perhaps setting this plugin's styling to match the app's.