DNM: Build PVC Images#309
Closed
holliefae wants to merge 22 commits into
Closed
Conversation
holliefae
force-pushed
the
intel-gpu-support-azimuthcloud
branch
from
March 20, 2025 00:31
0237153 to
d901fb2
Compare
holliefae
force-pushed
the
intel-gpu-support-azimuthcloud
branch
from
March 20, 2025 00:45
d901fb2 to
82a3745
Compare
holliefae
force-pushed
the
intel-gpu-support-azimuthcloud
branch
from
March 20, 2025 11:51
d01da47 to
c4d7c31
Compare
JohnGarbutt
reviewed
Mar 20, 2025
| - intel-fw-gpu | ||
| - intel-i915-dkms | ||
| - xpu-smi | ||
| state: present |
Contributor
There was a problem hiding this comment.
I think we might need to add MOK to make secure boot not fail:
https://dgpu-docs.intel.com/driver/configuring-secure-boot.html
This reverts commit f2900e4.
holliefae
force-pushed
the
intel-gpu-support-azimuthcloud
branch
from
March 25, 2025 15:46
30270a3 to
8a45745
Compare
holliefae
force-pushed
the
intel-gpu-support-azimuthcloud
branch
from
March 25, 2025 15:53
8a45745 to
7799995
Compare
JohnGarbutt
reviewed
Mar 28, 2025
| when: data_volumes.configure_nvme is undefined | ||
|
|
||
| - include_tasks: /etc/ansible-init/includes/data-volumes-configure-nvme.yml | ||
| when: data_volumes.configure_nvme |
Contributor
There was a problem hiding this comment.
Check for "lvm_disk_nvme" in openstack_metadata.
Probably this should be a separate role.
JohnGarbutt
reviewed
Mar 28, 2025
| set_fact: | ||
| lvm_groups: | ||
| - vgname: lvm-nvme | ||
| disks: "{{ openstack_metadata.lvm_disk_nvme | split(',') | map('trim') | list }}" |
Contributor
There was a problem hiding this comment.
When we can't find all the disks on this list on this host, we should skip doing this mount. Equally, we need to double check that the disks are not currently in use, I think. (maybe using ansible devices fact?)
Contributor
Author
|
Superseded by #312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to build PVC images