Set robotframework --exitonfailure flag by default.#361
Open
amanning9 wants to merge 6 commits into
Open
Conversation
irt-shpc
requested changes
Jul 23, 2026
|
|
||
| extraargs="" | ||
| if [[ $EXIT_ON_FAILURE == true ]]; then | ||
| extraargs="--exitonfailure $extraargs" |
Contributor
There was a problem hiding this comment.
Isn't $extraargs always empty here because line 25 has set to the empty string
If you delete line 25 and use
extraargs="--exitonfailure ${extraargs-}"
that will not blow up if $extraargs isn't set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one of the robot tests fails, robot carries on running all the other tests, even though they are going to fail as a whole.
We should fix this by failing fast in most cases, which will save CI resources, and maybe a bit of time.