Skip to content

A11y: improve search button accessible names #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
accesswatch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

A11y: improve search button accessible names #5641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d4e4a8
Improve accessible names for search buttons
accesswatch May 28, 2026
53dc8d4
Stabilize composer audit check for abandoned packages
accesswatch May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,18 @@ jobs:
- name: Run composer audit
run: |
cd az-quickstart-scaffolding
composer audit --no-dev --ignore-severity=low --ignore-severity=moderate
set +e
composer audit --no-dev --ignore-severity=low --ignore-severity=moderate > composer-audit.log 2>&1
composer_audit_status=$?
cat composer-audit.log
if [ "$composer_audit_status" -eq 0 ]; then
exit 0
fi
if [ "$composer_audit_status" -eq 2 ] && grep -q "No security vulnerability advisories found." composer-audit.log; then
echo "Composer audit reported only abandoned packages; continuing."
exit 0
fi
exit "$composer_audit_status"
Comment on lines +179 to +190

@joeparsons joeparsons May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We addressed the composer audit issue in a separate PR: #5657 so these changes are causing merge conflicts now.

Suggested change
set +e
composer audit --no-dev --ignore-severity=low --ignore-severity=moderate > composer-audit.log 2>&1
composer_audit_status=$?
cat composer-audit.log
if [ "$composer_audit_status" -eq 0 ]; then
exit 0
fi
if [ "$composer_audit_status" -eq 2 ] && grep -q "No security vulnerability advisories found." composer-audit.log; then
echo "Composer audit reported only abandoned packages; continuing."
exit 0
fi
exit "$composer_audit_status"
composer audit --no-dev --ignore-severity=low --ignore-severity=moderate --abandoned=report


yarn-audit:
name: yarn audit (security)
Expand Down
6 changes: 4 additions & 2 deletions themes/custom/az_barrio/templates/forms/input--search-block-button.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
* @see template_preprocess_input()
*/
#}
<button{{attributes}}>{{ attributes.value }}<span class="material-symbols-rounded">search</span></button>{{ children }}

<button{{ attributes }}>
{{ attributes.value }}
<span aria-hidden="true" class="material-symbols-rounded">search</span>
</button>{{ children }}

@trackleft trackleft May 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any change here other than syntax?

@joeparsons joeparsons May 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trackleft It's also adding aria-hidden="true" to the span element.


7 changes: 5 additions & 2 deletions themes/custom/az_barrio/templates/forms/input--search-block-form--submit.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,8 @@
* @see template_preprocess_input()
*/
#}
<button{{attributes.removeClass('btn-primary')}}><span class="material-symbols-rounded">search</span></button>{{ children }}

{% set button_label = attributes.value|default('Search'|t) %}
<button{{ attributes.removeClass('btn-primary').setAttribute('aria-label', button_label) }}>
<span class="visually-hidden">{{ button_label }}</span>
<span aria-hidden="true" class="material-symbols-rounded">search</span>
</button>{{ children }}
Loading