Medium-confidence a11y fixes: landmark labels and pager headings#5640
Open
accesswatch wants to merge 3 commits into
Open
Medium-confidence a11y fixes: landmark labels and pager headings#5640accesswatch wants to merge 3 commits into
accesswatch wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility semantics in the az_barrio theme by making navigation landmark labels more distinct and aligning pager headings with section-level heading structure.
Changes:
- Adds context-aware
aria-labelvalues to menu block<nav>elements. - Updates full and mini pager landmarks to use
aria-labelledby. - Promotes pager hidden headings from
h3toh2.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
themes/custom/az_barrio/templates/blocks/block--system-menu-block.html.twig |
Builds a contextual navigation label for system menu landmarks. |
themes/custom/az_barrio/templates/blocks/block--az-barrio-sidebar-menu.html.twig |
Adds sidebar/mobile context to sidebar menu landmark labels. |
themes/custom/az_barrio/templates/navigation/pager.html.twig |
Uses the hidden pagination heading as the nav label and updates heading level. |
themes/custom/az_barrio/templates/views/views-mini-pager.html.twig |
Applies the same pager landmark and heading semantics to mini pagers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joeparsons
reviewed
May 29, 2026
Contributor
|
Tugboat has finished building the preview for this pull request! Link: Dashboard: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
themes/custom/az_barrio/templates/blocks/block--system-menu-block.html.twigaria-label(e.g., mobile context) on<nav>.themes/custom/az_barrio/templates/blocks/block--az-barrio-sidebar-menu.html.twigaria-label(sidebar/mobile context) on<nav>.themes/custom/az_barrio/templates/navigation/pager.html.twigaria-labelledby+ upgrades hidden heading fromh3toh2.themes/custom/az_barrio/templates/views/views-mini-pager.html.twigaria-labelledby+ upgrades hidden heading fromh3toh2.Impact
landmark-unique,heading-order