feat!: rename Items to Values (#12)#21
Merged
Merged
Conversation
Rename SyncMap.Items() to SyncMap.Values() to match Go convention (maps.Values in stdlib 1.23). Pre-v1.0 under the new axonops module path with no known importers, so no deprecation shim. Touches: syncmap.go (method + godoc first line + local var), doc.go (package overview mentions Values instead of Items), syncmap_test.go (TestValues replaces TestItems; subtest names and assertions unchanged). No behaviour change; coverage remains 100%. CHANGELOG entry for this breaking rename is deferred to #17, which owns CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
SyncMap.Items() []VtoSyncMap.Values() []Vto match Go convention (maps.Valuesin stdlib 1.23). Pre-v1.0 breaking change; zero known importers under the axonops module path; no deprecation shim.Closes #12.
Diff
syncmap.go— method rename + godoc first line + internal local var.doc.go— package overview now listsKeys, and Valuesinstead ofKeys, and Items.syncmap_test.go—TestItems→TestValues; local vars renamed; subtest names and assertions unchanged.Verification
Agent gates
doc.go:30("Keys, and Items"); fixed in the same commit.make check).Out of scope
Test plan
github.com/axonops/syncmapconfirms zero importers (no breakage in the wild)