Pdk27 patch 2#28
Open
pdk27 wants to merge 221 commits into
Open
Conversation
* Tag EC2 instances used by plugin
… Spot Fleet) (#146) Multi capacity support (support of AutoScalingGroup additional to EC2 Spot Fleet)
* Handle EC2 Spot Fleet Modifying state and fix fleet widget
Label based configuration
* Add clarity to logs * Adding help text for minSpareSize
…und terminations triggered by plugin (#375) * rename EC2TerminationCause to EC2ExecutorInterruptionCause for clarity * -add and track EC2AgentTerminationReason when plugin triggers termination -rename force to overrideOtherSettings in scheduleToTerminate for clarity #363 * [fix] remove unnecessary decrement which could lead to -1 (has special meaning) [fix] remove misleading log and redundant set #363 * update and add tests * rename overrideOtherSettings to ignoreMinConstraints
* [fix] Terminate scheduled instances ONLY IF idle #363 * [fix] leave maxTotalUses alone and track remainingUses correctly add a flag to track termination of agents by plugin * [fix] Fix lost state (instanceIdsToTerminate) on configuration change [fix] Fix maxtotaluses decrement logic add logs in post job action to expose tasks terminated with problems #322 add and fix tests * add integration tests for configuration change leading to lost state and rebuilding lost state to terminate instances previously marked for termination
* [refactor] Added class comments for Jenkins extension points [refactor] Use Computer subtype in EC2RetentionStrategy * [refactor] Moving AWS files into their own package
* handling issues 347,364 * updating default for fleet items and adding specific error message when default is selected * updating error message for checkFleet * removing checkMethod info from fleet select entry --------- Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com>
* handling issue 329 * updating additonal slave terminology
* Removing a recently added integ test (need some refactoring to make it work) * Added a warning to cloud name description to prevent users from modifying it * Deleting files related to cloud instance tracking and reassignments * [fix] Remove references of oldId and EC2FleetCloudAware class, remove tracking of cloud instance [refactor] Added instanceId to FleetNode for clarity, added getDescriptor to return sub type [refactor] Dont provision if Jenkins is quieting down and terminating Fix #360 Fix #322
reflect changes in the constructor[0] [0] https://github.com/jenkinsci/ec2-fleet-plugin/blob/master/src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetCloud.java
…oud tracking (#401) * making exisitng duplicate cloud name editable * addressing pr comments and making corresponding changes for fleet label cloud * Update src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetCloud.java Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> * Update src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetLabelCloud.java Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> * Update src/main/resources/com/amazon/jenkins/ec2fleet/EC2FleetCloud/config.jelly Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> * Update src/main/resources/com/amazon/jenkins/ec2fleet/EC2FleetLabelCloud/config.jelly Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com> --------- Co-authored-by: Prathibha Datta Kumar <kprathib@amazon.com>
…#402) * changed suffix generation for CloudNames and handle empty string for CasC * fixed CloudNames unit tests to follow new functionality * added configuration-as-code tests for empty name
…ges (#404) * Adding missing config, warning for Spot Fleet usage, other minor changes * PR feedback * Fixing Groovy example
* move non-required values into databound setters and create validations * create default value constants for primitives of FleetClouds and clean up getters * create new constructors with CasC best practices * fix CasC unit tests * update casc docs to reflect new defaults, add unlisted fields to examples, and include EC2FleetLabelCloud examples * change default minSize to 0 in jelly for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the "Publish changelogs to GitHub Release" workflow per https://www.jenkins.io/doc/developer/plugin-development/plugin-release-tips/