Skip to content

Fix logic used to calculate BinaryValue's lenght #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cherchiga wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix logic used to calculate BinaryValue's lenght #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/sqs_extended_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,14 @@ def _validate_required_parameters(self, required_params: list, error_message: st

return

def _get_bytes_size_in_bytes(self, b: bytes) -> int:
"""
Responsible for calculating the size of a byte collection in bytes

:b: The byte collection whose size is to be determined.

"""
return len(b)

def _get_string_size_in_bytes(self, s: str) -> int:
"""
Expand Down Expand Up @@ -156,7 +163,7 @@ def _get_message_attributes_size(self, message_attributes: dict) -> int:

binarytype_value = value.get("BinaryValue", 0)
if binarytype_value:
total_message_attributes_size += self.get_string_size_in_bytes(binarytype_value)
total_message_attributes_size += self.get_bytes_size_in_bytes(binarytype_value)

return total_message_attributes_size

Expand Down Expand Up @@ -636,6 +643,7 @@ def add_client_attributes(self, class_attributes, **kwargs):
_delete_delete_payload_from_s3
)

class_attributes["get_bytes_size_in_bytes"] = _get_bytes_size_in_bytes
class_attributes["get_string_size_in_bytes"] = _get_string_size_in_bytes
class_attributes["get_reserved_attribute_name_if_present"] = _get_reserved_attribute_name_if_present
class_attributes["get_s3_key"] = _get_s3_key
Expand Down