feat(slime): add sglang patch for v0.5.12.post1.#72
Open
Linbo-Liu wants to merge 1 commit into
Open
Conversation
Contributor
|
@Linbo-Liu thanks for the PR! I looked into slime's mechanism to preserve prompt & response IDs. https://github.com/THUDM/slime/blob/main/slime/agent/adapters/openai.py. Since we will install slime anyway, could you investigate if there's something we can reuse, potentially in place of rllm-model-gateway? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The latest
slimerl/slime:latestimage uses sglangv0.5.12.post1. The sglang patch for v0.5.9sglang_token_ids.pycan't be successfully applied due to changes to sglang.Description of changes:
Add a patch compatible with sglang v0.5.12.post1 in
sglang_token_ids_v_0_5_12.py.Tested via
verify_sglang_token_ids.pywith sglang v0.5.12.post1 inslimerl/slime:latestdocker container. Test output:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.