Fix: Handle 'slot already exists' error gracefully during node join#307
Open
MonkeyGyu wants to merge 1 commit into
Open
Fix: Handle 'slot already exists' error gracefully during node join#307MonkeyGyu wants to merge 1 commit into
MonkeyGyu wants to merge 1 commit into
Conversation
When an apply worker crashes after creating a remote slot but before committing the local replication origin, subsequent restart attempts would fail with FATAL error because the slot already exists. This patch: - Catches ERRCODE_DUPLICATE_OBJECT (42710) error from CREATE_REPLICATION_SLOT - Logs a message and continues with the existing slot - Creates the local replication origin if it doesn't exist - Allows dynamic node addition to work without manual intervention
Contributor
|
Like the idea and it matches with TODO comment but when the slot already exists, the code assumes it's the correct slot (same plugin, same database). A malicious or stale slot with the same name but wrong configuration would silently be reused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A (addresses existing TODO in code)
Description of changes:
Fix handling of "slot already exists" error during dynamic node join.
When an apply worker crashes after creating a remote replication slot
but before committing the local replication origin, the worker enters
an infinite crash loop because CREATE_REPLICATION_SLOT fails with
"already exists" error.
This patch: