Fix Windows browser validation opening extra Chrome window#108
Open
awschristou wants to merge 1 commit into
Open
Fix Windows browser validation opening extra Chrome window#108awschristou wants to merge 1 commit into
awschristou wants to merge 1 commit into
Conversation
On Windows, running `chrome.exe --version` when Chrome is already running does not print version info to stdout. Instead it outputs "Opening in existing browser session." and opens a new browser window as a side effect. This caused two issues: 1. The Chromium detection check failed with "Browser is not Chromium-based" because the expected version string was not in stdout. 2. An extra Chrome window was spawned before the actual session launch, resulting in two browser windows appearing. Fix by checking the executable path name for known Chromium indicators (chrome, chromium, edge) before invoking --version. If the path already identifies the browser, skip the subprocess call entirely. The --version check is preserved as a fallback for unknown custom executables. Also check stderr in addition to stdout for the --version output, as some platforms may write version info there. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, running
chrome.exe --versionwhen Chrome is already running does not print version info to stdout. Instead it outputs "Opening in existing browser session." and opens a new browser window as a side effect.This caused two issues:
Fix by checking the executable path name for known Chromium indicators (chrome, chromium, edge) before invoking --version. If the path already identifies the browser, skip the subprocess call entirely. The --version check is preserved as a fallback for unknown custom executables.
Also check stderr in addition to stdout for the --version output, as some platforms may write version info there.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.