Skip to content

fix(dataops-project): grant SMUS user role read access to job scripts in project bucket #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcinc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(dataops-project): grant SMUS user role read access to job scripts in project bucket #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38dc177
fix(dataops-project): grant SMUS user role read access to job scripts…
marcinc May 19, 2026
3395577
fix(dataops-project): update diff baselines to reflect SMUS user role…
marcinc May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion ...prehensive.test-org-test-env-test-domain-test-dataops-project-comprehensive.baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3741,6 +3741,33 @@
},
"Sid": "/temp_ReadWrite"
},
{
"Action": "s3:GetObject*",
"Condition": {
"StringLike": {
"aws:PrincipalArn": "arn:aws:iam::test-account:role/datazone_usr_role_*"
}
},
"Effect": "Allow",
"Principal": {
"AWS": "*"
},
"Resource": {
"Fn::Join": [
"",
[
{
"Fn::GetAtt": [
"BucketprojectAACC6DD8",
"Arn"
]
},
"/deployment/*"
]
]
},
"Sid": "SmusUserRoleDeploymentRead"
},
{
"Action": [
"s3:PutObject*",
Expand Down Expand Up @@ -3863,7 +3890,8 @@
"projectdeploymentrole542A1AAB",
"Arn"
]
}
},
"arn:aws:iam::test-account:role/datazone_usr_role_*"
]
}
},
Expand Down
30 changes: 29 additions & 1 deletion ...config-datazone.test-org-test-env-test-domain-test-dataops-project-datazone.baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2312,6 +2312,33 @@
},
"Sid": "/temp_ReadWrite"
},
{
"Action": "s3:GetObject*",
"Condition": {
"StringLike": {
"aws:PrincipalArn": "arn:aws:iam::test-account:role/datazone_usr_role_*"
}
},
"Effect": "Allow",
"Principal": {
"AWS": "*"
},
"Resource": {
"Fn::Join": [
"",
[
{
"Fn::GetAtt": [
"BucketprojectAACC6DD8",
"Arn"
]
},
"/deployment/*"
]
]
},
"Sid": "SmusUserRoleDeploymentRead"
},
{
"Action": [
"s3:PutObject*",
Expand Down Expand Up @@ -2398,7 +2425,8 @@
"projectdeploymentrole542A1AAB",
"Arn"
]
}
},
"arn:aws:iam::test-account:role/datazone_usr_role_*"
]
}
},
Expand Down
30 changes: 29 additions & 1 deletion ...e-config-minimal.test-org-test-env-test-domain-test-dataops-project-minimal.baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,6 +1546,33 @@
},
"Sid": "/temp_ReadWrite"
},
{
"Action": "s3:GetObject*",
"Condition": {
"StringLike": {
"aws:PrincipalArn": "arn:aws:iam::test-account:role/datazone_usr_role_*"
}
},
"Effect": "Allow",
"Principal": {
"AWS": "*"
},
"Resource": {
"Fn::Join": [
"",
[
{
"Fn::GetAtt": [
"BucketprojectAACC6DD8",
"Arn"
]
},
"/deployment/*"
]
]
},
"Sid": "SmusUserRoleDeploymentRead"
},
{
"Action": [
"s3:PutObject*",
Expand Down Expand Up @@ -1632,7 +1659,8 @@
"projectdeploymentrole542A1AAB",
"Arn"
]
}
},
"arn:aws:iam::test-account:role/datazone_usr_role_*"
]
}
},
Expand Down
30 changes: 29 additions & 1 deletion ...nfig-sagemaker.test-org-test-env-test-domain-test-dataops-project-sagemaker.baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,6 +1815,33 @@
},
"Sid": "/temp_ReadWrite"
},
{
"Action": "s3:GetObject*",
"Condition": {
"StringLike": {
"aws:PrincipalArn": "arn:aws:iam::test-account:role/datazone_usr_role_*"
}
},
"Effect": "Allow",
"Principal": {
"AWS": "*"
},
"Resource": {
"Fn::Join": [
"",
[
{
"Fn::GetAtt": [
"BucketprojectAACC6DD8",
"Arn"
]
},
"/deployment/*"
]
]
},
"Sid": "SmusUserRoleDeploymentRead"
},
{
"Action": [
"s3:PutObject*",
Expand Down Expand Up @@ -1901,7 +1928,8 @@
"projectdeploymentrole542A1AAB",
"Arn"
]
}
},
"arn:aws:iam::test-account:role/datazone_usr_role_*"
]
}
},
Expand Down
15 changes: 14 additions & 1 deletion ...es/constructs/L3/dataops/dataops-project-l3-construct/lib/dataops-project-l3-construct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,12 +1501,25 @@ export class DataOpsProjectL3Construct extends MdaaL3Construct {
});
tempPolicy.statements().forEach(statement => projectBucket.addToResourcePolicy(statement));

// SMUS creates per-user roles named datazone_usr_role_<projectId>_<userId> at session time.
// These are not known to MDAA at deploy time so they cannot be added to roleExcludeIds.
const smusUserRoleArnPattern = `arn:aws:iam::${this.account}:role/datazone_usr_role_*`;
const smusUserRoleDeploymentRead = new PolicyStatement({
sid: 'SmusUserRoleDeploymentRead',
effect: Effect.ALLOW,
actions: RestrictObjectPrefixToRoles.READ_ACTIONS,
resources: [projectBucket.arnForObjects('deployment/*')],
conditions: { StringLike: { 'aws:PrincipalArn': smusUserRoleArnPattern } },
});
smusUserRoleDeploymentRead.addAnyPrincipal();
projectBucket.addToResourcePolicy(smusUserRoleDeploymentRead);

//Default Deny Policy
//Any role not specified in props is explicitely denied access to the bucket
const bucketRestrictPolicy = new RestrictBucketToRoles({
s3Bucket: projectBucket,
roleExcludeIds: [...this.getAllRoleIds(), lakeFormationRole.roleId, datazoneUserRole.roleId],
principalExcludes: [projectDeploymentRole.roleArn],
principalExcludes: [projectDeploymentRole.roleArn, smusUserRoleArnPattern],
});
projectBucket.addToResourcePolicy(bucketRestrictPolicy.denyStatement);
projectBucket.addToResourcePolicy(bucketRestrictPolicy.allowStatement);
Expand Down
23 changes: 23 additions & 0 deletions packages/constructs/L3/dataops/dataops-project-l3-construct/test/project.compliance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,29 @@ describe('MDAA Compliance Stack Tests', () => {
});
});

test('SmusUserRoleDeploymentRead', () => {
template.hasResourceProperties('AWS::S3::BucketPolicy', {
PolicyDocument: {
Statement: Match.arrayWith([
Match.objectLike({
Sid: 'SmusUserRoleDeploymentRead',
Effect: 'Allow',
Action: 's3:GetObject*',
Principal: { AWS: '*' },
Resource: {
'Fn::Join': ['', [{ 'Fn::GetAtt': ['BucketprojectAACC6DD8', 'Arn'] }, '/deployment/*']],
},
Condition: {
StringLike: {
'aws:PrincipalArn': Match.stringLikeRegexp('datazone_usr_role_\\*$'),
},
},
}),
]),
},
});
});

test('DeploymentRoleReadWrite', () => {
template.hasResourceProperties('AWS::S3::BucketPolicy', {
PolicyDocument: {
Expand Down