chore: skip changelogen GitHub release prompt in pnpm release#13
Merged
Conversation
changelogen --release opens a browser to manually create a GitHub release by default (and does NOT push the commit/tag unless --push is given). That asymmetry let a release form be submitted before the bump commit+tag were pushed, creating the tag on the wrong commit (see unjs/changelogen#237). Add --no-github so pnpm release only bumps, commits, and tags locally. The GitHub Release is created by the Release workflow (changelogen gh release) after npm publish succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
--no-githubto the rootreleasescript sopnpm releaseonly bumps the version, writes the changelog, commits, and tags locally.Why
changelogen --releaseopens a browser to manually create a GitHub release by default, but does not push the commit/tag unless--pushis given. That asymmetry is a footgun (upstream unjs/changelogen#237): submitting the release form before the bump commit+tag are pushed creates the tag on the wrong commit — which is exactly howv0.2.0ended up tagged on a pre-bump commit and the npm publish failed.The GitHub Release is already created by the
Releaseworkflow (changelogen gh release) after npm publish succeeds, so the local prompt is redundant and dangerous.Flow after this change