Skip to content

Strokes: tessellate thick strokes to triangles so joint and cap styles apply #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neilrackett wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Strokes: tessellate thick strokes to triangles so joint and cap styles apply #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions lib/draw/GraphicsFactoryStrokes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,35 @@ export class GraphicsFactoryStrokes {
const path = paths[i];
const style = (<GraphicsStrokeStyle<any>>path.style);

shape = targetGraphics.popEmptyStrokeShape();

path.prepare();

// Thick strokes are tessellated to triangles so joint styles (miter/bevel/
// round) and cap styles actually apply: GPU-expanded LineElements draw every
// segment as an independent quad and cannot form joints, which leaves a
// notch at each corner of a polyline. Hairlines and very thin strokes keep
// the fast LineElements path — joints are invisible at those sizes.
if (style.scaleMode !== LineScaleMode.HAIRLINE && style.thickness > 1.5) {
const triElements = this.getTriangleElements([path], false, style.scaleMode);

if (triElements) {
const triData = {
style: new Style(),
sampler: new ImageSampler(),
material: null
};

UnpackFillStyle[path.style.fillStyle.data_type](path.style.fillStyle, triData);

shape = Shape.getShape(triElements, triData.material, triData.style);

targetGraphics.addShapeInternal(shape);
}

continue;
}

shape = targetGraphics.popEmptyStrokeShape();

// if (targetGraphics.scaleStrokes != null) { //use LineElements
const elements = this.fillLineElements(
[path],
Expand Down