Fix anonymous access for other registries#69
Conversation
jsoo1
left a comment
There was a problem hiding this comment.
Thank you! This LGTM, but I would like some notes on testing done for this.
|
I've added some unit tests for the parser. I was testing it with Docker Hub registry and our internal one (both headers added to test cases, though obfuscated). Also checked gcr.io, but they allow anonymous access without tokens |
If you wouldn't mind adding the manual tests done to the PR description, that would be excellent. |
jsoo1
left a comment
There was a problem hiding this comment.
Thank you very much, no more blocking issues from me.
This should allow anonymous access to other registries than Docker Hub by parsing
WWW-Authenticateheader instead of havin hardcoded URLs for hub.The parser is done according to RFC7235
https://datatracker.ietf.org/doc/html/rfc7235#autoid-30
Closes #68
Manual testing done:
Verification of how different registries handle anonymous access:
Google Container/Artifact Registry
Docker Hub
Running hocker-manifest
Google Container/Artifact Registry
Docker Hub