Add libserialport as an external library for MSVC build - #2111
Conversation
|
Not working yet. |
|
Related issue from avrdude-libserialport |
|
Okay, I think we may need to re-organize libserialport as what Marius designed how the external libraries should be organized. https://github.com/avrdudes/libftdi Basically: |
|
I have created the following avrdude-libserialport for this purpose. |
|
One step closer but not yet there. |
Add conditional compilation definition for MSVC.
Added compile definitions for MSVC to treat libserialport as an inline static header dependency.
Removed redundant comments and clarified existing ones in CMakeLists.txt.
Updated CMake configuration to define SP_API for libserialport.
Updated the GIT_TAG for libserialport to a newer commit and removed MSVC-specific compile definitions.
Updated the GIT_TAG for libserialport to a newer commit and removed unnecessary MSVC-specific linking.
|
After a lot of trial and error, now it seems to be okay. |
|
I think it is better to move my libserialport MSVC port (which is modeled after Marius' libftdi/libusb organization) here under avrdude organization. Just wondering if you have the right to create a new repo libserialport-avrdude and grant me the admin right. I do not want to touch the existing fork here since I want to use it to contribute to the upstream libserialport. |
|
I already have access to the following repo. I would like to be able to be the admin of the following repo, or at least with code commit right. If possible, I am wondering if you can open the organization access to me, @stefanrueger and @MCUdude, so that we can create new repo and also carry out admin work on the above-mentioned avrdude MSVC supporting repos. libelf repo might be even useful for macOS in the future. |
|
Oops, wrong PR closed |
|
This PR should be post 8.2 release. Converted to draft first -- we need to sort out the repo issue first and update this PR. |
|
I already have access to the following repo. I would like to be able to be the admin of the following repo, or at least with code commit right. Thanks. |
|
Close this PR for now as the repo issue has not been sorted out. |
This is to address Issue #1552.