skip -bios when IGVM supplies guest firmware#4357
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies virttest/qemu_vm.py to prevent the inclusion of the -bios parameter when IGVM is enabled, avoiding potential firmware conflicts. A review comment suggests using get_boolean for the enable_igvm parameter to more robustly handle various truthy values like "on" or "true" instead of a strict string comparison with "yes".
Only insert the -bios StrDev when bios_path is set and enable_igvm is not yes. Signed-off-by: Srikanth Aithal <srikanth.aithal@amd.com>
|
Closing this PR due to current team constraints. This is part of a broader effort to triage all in-flight work across our upstream repos. If this work is still needed, please feel free to reopen and it will be picked up. Apologies for any inconvenience. |
|
This is required. Please let me know if I can help in any way to expedite its merging. I dont see any option to reopen the PR |
2 participants
Only insert the -bios StrDev when bios_path is set and enable_igvm is not yes.