virttest: fix qemu version parsing#4350
Conversation
|
I had custom qemu built when queried on version it returned: In above case current parsing fails: After fix: |
There was a problem hiding this comment.
Code Review
This pull request updates the QEMU version parsing logic to make the parenthetical build/distro suffix optional, improving compatibility with various version string formats. Changes include regex updates in env_process.py and utils_qemu.py, logic adjustments in requirement_checks.py, and a new unit test. Feedback suggests consolidating the QEMU_VERSION_RE definitions into a single location to reduce code duplication and improve maintainability.
QEMU -version output without a parenthetical build/distro suffix (e.g. some upstream builds) did not match the old QEMU_VERSION_RE, so requirement_checks failed to read the version and canceled tests. This commit fixes it and also adds unittest for the same Signed-off-by: Srikanth Aithal <srikanth.aithal@amd.com>
c85f991 to
dcf8d1e
Compare
|
Closing this PR due to current team constraints. This is part of a broader effort to triage all in-flight work across our upstream repos. If this work is still needed, please feel free to reopen and it will be picked up. Apologies for any inconvenience. |
|
This PR as well is fixing a issue in the framework, I would appreciate if this gets reopened. |
Current QEMU_VERSION_RE required parenthetical,
but on custom qemu builds prints only “QEMU emulator version X.Y.Z” on the first line so requirement_checks could not read the version and canceled tests.
This commit fixes it and also adds unittest for the same