fix(menubar): isolate currentTime reads to prevent sub-menu flicker#188
Open
paaloeye wants to merge 1 commit into
Open
fix(menubar): isolate currentTime reads to prevent sub-menu flicker#188paaloeye wants to merge 1 commit into
paaloeye wants to merge 1 commit into
Conversation
paaloeye
commented
May 25, 2026
paaloeye
commented
- Extract progress bar and time labels into SongProgressView struct so only that leaf view is invalidated on each lyric-tick currentTime update
- MenubarWindowView no longer reads currentTime, keeping Picker sub-menus for Source Language and Target Language stable during playback
- Extract progress bar and time labels into SongProgressView struct so only that leaf view is invalidated on each lyric-tick currentTime update - MenubarWindowView no longer reads currentTime, keeping Picker sub-menus for Source Language and Target Language stable during playback Co-Authored-By: Claude Code 2.1.150 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-Off-By: Paal Øye-Strømme <paal.o.eye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.