Add Furigana to Karaoke View#176
Open
Toby-Shi-cloud wants to merge 2 commits into
Open
Conversation
Owner
|
that looks sick!!!! awesome!! i've had many personal issues going on, but will try to take a look soon |
Author
Thanks for replying. In fact, I find some kanji are not correctly annotated or are not annotated at all. However, this seems to be because some kanji in the lyrics are uncommon (or use uncommon pronunciations) and the IPADic library cannot handle them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#175
I add furigana support to Karaoke View.
Honestly, I'm not familiar with AppKit. The structure
RubyTextLabelis mostly generated by Gemini, but it works perfectly on my machine.