fix(ci): keep embedded example .go files in pages deploy#7
Merged
Conversation
The assemble step deleted every .go file from the site, but docsify embeds docs/assets/examples/*/main.go via ':include', so all code snippets on the docs site 404'd. Only strip test files instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pages.ymlranfind _site -name '*.go' -delete, stripping every.gofile from the deployed site.docs/assets/examples/*/main.godirectly via':include :type=code', so every code snippet on the docs site returned 404 (e.g.GET /paper/assets/examples/simplest/main.go).*_test.go, so the embeddedmain.goexamples ship with the site while test files stay out of the deploy.Where should the reviewer start
.github/workflows/pages.yml— the one-line change in the "Assemble site" step.docs/examples/simplest.md— example of a docsify':include'that depends on these files being deployed.Notes
Verified locally by simulating the assemble step: all
assets/examples/*/main.gofiles survive and zero*_test.gofiles remain. The only non-test.gofiles underdocs/are the embedded examples, so nothing unwanted is added to the deploy.🤖 Generated with Claude Code