Skip to content

feat(core/types): Header hook PostCopy#106

Merged
qdm12 merged 7 commits into
mainfrom
qdm12/core/types/header-copy-hooks
Feb 4, 2025
Merged

feat(core/types): Header hook PostCopy#106
qdm12 merged 7 commits into
mainfrom
qdm12/core/types/header-copy-hooks

Conversation

@qdm12

@qdm12 qdm12 commented Jan 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Why this should be merged

Introduce header copy hooks to get rid of core/types.CopyHeader in coreth and subnet-evm

How this works

Header copy hooks 🎉

How this was tested

@qdm12 qdm12 changed the title feat(core/types): header copy hooks feat(core/types): Header Copy hook Jan 21, 2025
ARR4N
ARR4N requested changes Jan 28, 2025
View reviewed changes
Comment thread core/types/block.go Outdated
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch from 5b49266 to 9236b52 Compare January 31, 2025 18:51
@qdm12 qdm12 marked this pull request as ready for review February 3, 2025 11:54
@qdm12 qdm12 requested a review from ARR4N February 3, 2025 11:54
@ARR4N

ARR4N commented Feb 3, 2025

Copy link
Copy Markdown
Collaborator

Why not merge into main? Is there a reason to batch PRs for a later re-review and merge?

@qdm12

qdm12 commented Feb 3, 2025

Copy link
Copy Markdown
Author

Why not merge into main?

I needed the fixes of darioush/libevm-phase-2.5 to make it work in coreth. How are we planning to handle the few fix commits in darioush/libevm-phase-2.5 in the end?

Is there a reason to batch PRs for a later re-review and merge?

Not at all, I would rather not 😉

ARR4N
ARR4N approved these changes Feb 3, 2025
View reviewed changes

@ARR4N ARR4N left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestions that don't require re-review

Comment thread core/types/block.libevm_test.go Outdated
Comment thread core/types/block.libevm_test.go Outdated
@ARR4N

ARR4N commented Feb 3, 2025

Copy link
Copy Markdown
Collaborator

Why not merge into main?

I needed the fixes of darioush/libevm-phase-2.5 to make it work in coreth. How are we planning to handle the few fix commits in darioush/libevm-phase-2.5 in the end?

Is there a reason to batch PRs for a later re-review and merge?

Not at all, I would rather not 😉

Was it only the change to the legacy package that's absolutely required? If so, can you please open another PR and take a closer look re avoiding gas refunds I mentioned on DM?

@qdm12 qdm12 changed the base branch from darioush/libevm-phase-2.5 to main February 4, 2025 15:01
@qdm12 qdm12 changed the title feat(core/types): Header Copy hook feat(core/types): Header hook PostCopy Feb 4, 2025
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch from edde146 to 18383c7 Compare February 4, 2025 15:03
@qdm12 qdm12 force-pushed the qdm12/core/types/header-copy-hooks branch from 18383c7 to def07f8 Compare February 4, 2025 15:04
@qdm12

qdm12 commented Feb 4, 2025

Copy link
Copy Markdown
Author

Gas fix for branch darioush/libevm-phase-2.5 is in its PR #114

@qdm12 qdm12 merged commit ee93f60 into main Feb 4, 2025
@qdm12 qdm12 deleted the qdm12/core/types/header-copy-hooks branch February 4, 2025 15:56
@ARR4N ARR4N mentioned this pull request Feb 11, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ARR4N ARR4N ARR4N approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qdm12 @ARR4N