Restore removal of old addresses - #2244
Merged
Merged
Conversation
Member
Author
|
This PR is actually problematic and will be fixed once we upgrade to libp2p/rust-libp2p#4596 Example above is a complete mess, identify doesn't return external addresses for some reason, some of the Kademlia addresses are with and some without |
Member
Author
|
Checking strings is not the most efficient solution, but it is the most compact and shouldn't be a huge bottleneck |
Member
Author
|
multiformats/rust-multiaddr#105 once resolved will help to avoid dealing with strings |
shamil-gadelshin
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was supposed to restore it before merging #2242.
Restored version has filtering condition flipped (that was a bug in the old version that had to be corrected).
Code contributor checklist: