Skip to content

Adding public URLs for tabular benchmark#121

Open
Neeratyoy wants to merge 102 commits into
developmentfrom
add-tabular-urls
Open

Adding public URLs for tabular benchmark#121
Neeratyoy wants to merge 102 commits into
developmentfrom
add-tabular-urls

Conversation

@Neeratyoy

Copy link
Copy Markdown
Collaborator

Added the figshare public URLs. Couldn't successfully test it though.

Tried the following:

from hpobench.benchmarks.ml_mmfb import TabularBenchmark
benchmark = TabularBenchmark(data_dir=None, model="svm", task_id=10101)

Failed with the error TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' at L98 of hpobench/util/data_manager.py

Neeratyoy added 30 commits June 23, 2021 20:32
PhMueller and others added 4 commits August 19, 2021 14:55
This would cause an error since importing stuff for the tab benchmarks would require the pybnn stuff.
@Neeratyoy Neeratyoy requested a review from PhMueller August 19, 2021 19:47
@codecov

codecov Bot commented Aug 31, 2021

Copy link
Copy Markdown

Codecov Report

Merging #121 (6394521) into development (1a789b7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #121      +/-   ##
===============================================
+ Coverage        44.34%   44.37%   +0.02%     
===============================================
  Files               41       41              
  Lines             2336     2337       +1     
===============================================
+ Hits              1036     1037       +1     
  Misses            1300     1300              
Impacted Files Coverage Δ
hpobench/util/data_manager.py 57.50% <100.00%> (+0.09%) ⬆️

Base automatically changed from PR_Multi-fidelity-tabular-benchmarks to development September 1, 2021 07:44
@Neeratyoy

Copy link
Copy Markdown
Collaborator Author

@PhMueller
this branch is now pointing to dev with the other big PR being merged
we could merge this directly to dev?
and for future updates to the URLs I could just have another PR doing so?

@Neeratyoy

Copy link
Copy Markdown
Collaborator Author

@KEggensperger updated with changes for CRC rerunning, involving the cost and optimization budgets.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.37%. Comparing base (1a789b7) to head (6394521).
⚠️ Report is 34 commits behind head on development.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #121      +/-   ##
===============================================
+ Coverage        44.34%   44.37%   +0.02%     
===============================================
  Files               41       41              
  Lines             2336     2337       +1     
===============================================
+ Hits              1036     1037       +1     
  Misses            1300     1300              
Files with missing lines Coverage Δ
hpobench/util/data_manager.py 57.50% <100.00%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants