Fixed issue 99#100
Merged
Merged
Conversation
Version release v0.1.2
Adjust __get_state to ignore timer as class attribute to make it work with dask
… (n_workers>1) caused the history to be disordered. This fix adds the bracket_id to the history dataframe and sorts the history by (bracket_id, fidelity, config_id) to emulate a serial execution history without disordering allowing for the tell(resume=True) function to work as intended. Additionally, updated deprecated usage of config.get_dictionary() to dict(config).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issue #99 where resuming previous parallel run (n_wokers>1) caused the history to be disordered.
This fix adds the bracket_id to the history dataframe and sorts the history by (bracket_id, fidelity, config_id) to emulate a serial execution history to prevent disordering and therefore allowing the tell(resume=True) function to work as intended.
I included the bracket_id also in the history written into the history.parquet, but there the sorting is not applied, to allow the user to understand the actual execution history better.
Additionally, updated deprecated usage of config.get_dictionary() to dict(config).
All tests ran without any issues.