Stage B, PR 3: PortableFont v3 with full layer-stack round-trip#67
Merged
Conversation
Splits the monolithic portable.ts into a directory with one module per concern (codec, types, export, import dispatch, v2 shim). v3 serialises the full layer stack — per-layer pixels, offsets, visibility, lock, color, preview — so multi-layer fonts no longer lose layers on JSON round-trip. v2 bundles are still accepted via import-v2.ts: each v2 glyph reconstitutes as a single-base-layer v3 glyph, with the v2 top-level xoffset/yoffset/xadvance lifted onto `bmf`. v1 still throws — no v1 data is worth a shim. ADR-0001 amended with the per-version import shim policy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portable.tsinto a directory:codec,types,export,import(dispatch),import-v2(shim). Public API at@/core/font/portableis unchanged.import-v2.ts: each v2 glyph reconstitutes as a single-base-layer v3 glyph; the v2 top-level xoffset/yoffset/xadvance lift ontobmf. v1 still throws.Test plan
pnpm test(109 tests, including new multi-layer v3 round-trip + v2 shim cases)pnpm buildpnpm lintmainbefore this PR; confirm it loads with a single base layer and correct BMF metadataUnsupported font version: 1🤖 Generated with Claude Code