prefer gpg2 when possible#33
Open
haarg wants to merge 1 commit into
Open
Conversation
On systems that have both 'gpg' and 'gpg2', 'gpg' will sometimes be gpg 1. Prefer 'gpg2', which is more likely to be the newer version. This can be important, because gpg 1 does not include the key fingerprint when generating a signature, instead only including the key id. This is true for all versions of gpg prior to 2.1.16. And gpg versions 2.3.0 and newer only support the --auto-key-retrieve option when the signature includes the fingerprint.
Collaborator
|
Looks fine - again since it been 2 years and concerns @haarg |
timlegge
approved these changes
Aug 29, 2024
timlegge
left a comment
timlegge
left a comment
Collaborator
There was a problem hiding this comment.
tests fine lgtm - gpg likely default to version 2 in most case now but accepting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On systems that have both 'gpg' and 'gpg2', 'gpg' will sometimes be gpg
This can be important, because gpg 1 does not include the key
fingerprint when generating a signature, instead only including the key
id. This is true for all versions of gpg prior to 2.1.16. And gpg
versions 2.3.0 and newer only support the --auto-key-retrieve option
when the signature includes the fingerprint.