Enable stream-unzip under Python 3.14#294
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the Python 3.14 restriction for the stream-unzip dependency and makes ZIP archive extraction always use the streaming implementation when num_workers == 1, simplifying tests by assuming stream-unzip is always available. Flow diagram for ZIP archive extraction decision logicflowchart TD
A[get_archive called] --> B{src_path ends with .zip?}
B -- No --> C[Use non-ZIP extraction path]
B -- Yes --> D{num_workers == 1?}
D -- No --> E[Use non-streaming ZIP extraction path]
D -- Yes --> F[Call _get_archive_streaming]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the restriction to not install
stream-unzipunder Python 3.14, as it now simply works. I guess one of its dependencies was not working with Python 3.14 before.