Skip to content

Enable stream-unzip under Python 3.14#294

Merged
hagenw merged 6 commits into
mainfrom
streamzio-python-3.14
Apr 30, 2026
Merged

Enable stream-unzip under Python 3.14#294
hagenw merged 6 commits into
mainfrom
streamzio-python-3.14

Conversation

@hagenw
Copy link
Copy Markdown
Member

@hagenw hagenw commented Apr 22, 2026

Removes the restriction to not install stream-unzip under Python 3.14, as it now simply works. I guess one of its dependencies was not working with Python 3.14 before.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 22, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the Python 3.14 restriction for the stream-unzip dependency and makes ZIP archive extraction always use the streaming implementation when num_workers == 1, simplifying tests by assuming stream-unzip is always available.

Flow diagram for ZIP archive extraction decision logic

flowchart TD
    A[get_archive called] --> B{src_path ends with .zip?}
    B -- No --> C[Use non-ZIP extraction path]
    B -- Yes --> D{num_workers == 1?}
    D -- No --> E[Use non-streaming ZIP extraction path]
    D -- Yes --> F[Call _get_archive_streaming]
Loading

File-Level Changes

Change Details Files
Always depend on and require stream-unzip, including on Python 3.14.
  • Remove the Python version marker from the stream-unzip dependency so it is installed on all supported Python versions
pyproject.toml
Unconditionally use streaming ZIP extraction when num_workers == 1.
  • Drop the STREAM_UNZIP_AVAILABLE guard from the get_archive streaming branch so it runs for .zip archives whenever num_workers == 1
audbackend/core/backend/base.py
Assume stream-unzip is available in streaming-related tests instead of skipping when it is missing.
  • Remove ImportError-based skip logic from filesystem backend streaming tests
  • Remove ImportError-based skip logic from Artifactory backend streaming tests
  • Remove ImportError-based skip logic from Minio backend streaming tests
tests/test_backend_filesystem.py
tests/test_backend_artifactory.py
tests/test_backend_minio.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hagenw hagenw changed the title Test stream-unzip under Python 3.14 Enable stream-unzip under Python 3.14 Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (fe48d2c) to head (4e00344).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
audbackend/core/backend/base.py 100.0% <100.0%> (ø)
audbackend/core/interface/unversioned.py 100.0% <ø> (ø)
audbackend/core/interface/versioned.py 100.0% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hagenw hagenw marked this pull request as ready for review April 22, 2026 07:59
sourcery-ai[bot]

This comment was marked as resolved.

@hagenw hagenw merged commit be13a49 into main Apr 30, 2026
13 checks passed
@hagenw hagenw deleted the streamzio-python-3.14 branch April 30, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant