Fix audb.available() for S3 / Minio backends#464
Merged
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThe PR fixes the Sequence diagram for S3/MinIO object listing in audb.available()sequenceDiagram
participant User
participant audb as audb.available()
participant Backend
participant S3MinIO as S3/MinIO
User->>audb: Call audb.available()
audb->>Backend: Initialize backend client
Backend->>S3MinIO: list_objects(repository.name)
S3MinIO-->>Backend: Return object list
Backend->>audb: Process object names
audb->>Backend: list_objects(repository.name, f"{name}/")
Backend->>S3MinIO: List objects with prefix
S3MinIO-->>Backend: Return versioned object list
Backend->>audb: Process versioned object names
audb-->>User: Return available databases
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the code introduced in #458 for S3/Minio backends and
audb.available().We still cannot add a test for it, this will be done later when we are ready for #450.
Summary by Sourcery
Bug Fixes: