Add MinIO support with audbackend>=2.1.0#453
Merged
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis PR adds MinIO backend support by updating the backend registry and modifying the documentation to be more generic for multiple backend types. The implementation leverages audbackend>=2.1.0 which includes MinIO support, while maintaining the existing Artifactory and file-system backends. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @hagenw - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider maintaining specific documentation examples for each backend type (Artifactory, FileSystem, and MinIO) in the docstring rather than using a generic description for non-Artifactory cases. This would make it clearer for users working with different backends.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
hagenw
commented
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for MinIO and S3 backends by depending on
audbackend>=2.1.0.It does not moves the public repository to S3 as proposed in #450, but stays with Artifactory.
Updated README:
The new backend is listed as
miniounder the registered backends:The docstring of
audb.Repository.create_backend_interface()has been updated to reflect that we have more than two backends now:Summary by Sourcery
Integrate MinIO support by updating the backend registry and modifying the docstring to reflect the new backend options. This change depends on audbackend version 2.1.0 or higher.
New Features:
Enhancements: