Improvements on filtering, forbidden tags, and debugging#37
Merged
Conversation
…ey are not sent to be translated.
…p', 'var', 'noscript', 'template', 'time', 'math', 'canvas', 'data', 'output', 'meter', 'progress', 'slot' - Add filter reject if html element contains the aria-hidden attribute. - Wrap the console log of options to only show if verboseOutput is true. - Run build for new index.js and map files.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the translation widget's filtering capabilities by expanding forbidden HTML tags, improving accessibility compliance, and adding conditional debugging output. The changes also modernize the CI/CD pipeline to use currently supported Node.js versions.
- Expands forbidden tags list to include semantic and technical elements that shouldn't be translated
- Adds filtering for aria-hidden elements and HTML comments to improve accessibility compliance
- Implements conditional console logging based on verboseOutput setting
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/customTreeWalker.ts | Expands forbidden tags list and adds filtering for aria-hidden elements and comments |
| src/widget.tsx | Wraps debug console output in conditional check for verboseOutput option |
| .github/workflows/main.yml | Updates Node.js versions and GitHub Actions to currently supported versions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kyledaviswx
changed the title
ben-hamelin
approved these changes
Jul 22, 2025
Collaborator
ben-hamelin
left a comment
ben-hamelin
left a comment
There was a problem hiding this comment.
@kyledaviswx these look good! Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to issues:
#35
#30