Skip to content

feat(desktop): unify dblclick-maximize across mac/win/linux#65

Merged
attson merged 3 commits into
mainfrom
feat/titlebar-dblclick-maximize
May 21, 2026
Merged

feat(desktop): unify dblclick-maximize across mac/win/linux#65
attson merged 3 commits into
mainfrom
feat/titlebar-dblclick-maximize

Conversation

@attson
Copy link
Copy Markdown
Owner

@attson attson commented May 21, 2026

Summary

  • After PR feat(desktop): unified title bar across mac/win/linux #64 (unified title bar), double-clicking the empty title bar area did nothing on macOS — TitleBarHiddenInset lets the WebKit view eat the dblclick before NSWindow can route it to system zoom.
  • Drop the darwin-specific guard in onTitleDblClick so all three platforms run the same WindowToggleMaximise() path.
  • Test reversal: the prior "darwin does NOT call WindowToggleMaximise" assertion is now "darwin DOES call WindowToggleMaximise". 16 tests in TitleBar.test.ts, count unchanged.

Test plan

Spec: docs/superpowers/specs/2026-05-20-titlebar-dblclick-maximize-design.md
Plan: docs/superpowers/plans/2026-05-20-titlebar-dblclick-maximize.md

@attson attson merged commit 6cdd2f5 into main May 21, 2026
7 checks passed
@attson attson deleted the feat/titlebar-dblclick-maximize branch May 21, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant