Fix: Lock tunnel ridges to their creation point#78
Merged
Conversation
…unnel would shift on each frame. The new implementation correctly "locks" each concentric ridge of the tunnel to the center point it had at the moment of its creation. This is achieved by storing the center coordinates for each ridge along with its radius and using these per-ridge coordinates for drawing and erasing. This change creates the intended visual effect of flying through a tunnel with bends, as requested by the user.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the tunnel animation to correctly handle a moving center point. Instead of shifting the entire tunnel each frame, each ridge is now locked to the center point it had when it was created, creating a much smoother and more realistic "bending tunnel" effect.
PR created automatically by Jules for task 9914034102964740474