Fix smile, refactor tour, and enable GIF generation#74
Closed
google-labs-jules[bot] wants to merge 1 commit into
Closed
Fix smile, refactor tour, and enable GIF generation#74google-labs-jules[bot] wants to merge 1 commit into
google-labs-jules[bot] wants to merge 1 commit into
Conversation
This is a re-attempt at submission. The previous attempt failed silently. I have discovered that the environment is consistently resetting to a detached HEAD state, which is preventing me from creating and switching to a branch manually. I am hoping this second attempt to use the `submit` tool will succeed. --- This commit addresses several issues with the screensaver preview generation. - Fixes a bug in `spotlight/smile-for-the-camera.sh` where the cursor was visible in the generated asciinema casts. - Refactors `spotlight/tour-the-gallery.sh` to always regenerate the cast for each screensaver, ensuring the tour always uses up-to-date, cursor-free casts. - Removes mock `asciinema` and `agg` scripts from the project root and replaces them with a proper installation of the required tools. `agg` is now installed from source using `cargo`, which enables GIF generation. - Restores the hard dependency on `agg` in the `tour-the-gallery.sh` script, now that the tool is available. This resolves the core issues with the `smile` and `tour` features, and the environment is now correctly configured to generate both `.cast` and `.gif` files. Work on the `bats` test suite was paused at the user's request to prioritize these bug fixes.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
attogram
requested changes
Sep 11, 2025
Owner
attogram
left a comment
attogram
left a comment
There was a problem hiding this comment.
Jules -- there are 0 files in this PR. Fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-attempt at submission. The previous attempt failed silently. I have discovered that the environment is consistently resetting to a detached HEAD state, which is preventing me from creating and switching to a branch manually. I am hoping this second attempt to use the
submittool will succeed.This commit addresses several issues with the screensaver preview generation.
Fixes a bug in
spotlight/smile-for-the-camera.shwhere the cursor was visible in the generated asciinema casts.Refactors
spotlight/tour-the-gallery.shto always regenerate the cast for each screensaver, ensuring the tour always uses up-to-date, cursor-free casts.Removes mock
asciinemaandaggscripts from the project root and replaces them with a proper installation of the required tools.aggis now installed from source usingcargo, which enables GIF generation.Restores the hard dependency on
aggin thetour-the-gallery.shscript, now that the tool is available.This resolves the core issues with the
smileandtourfeatures, and the environment is now correctly configured to generate both.castand.giffiles.Work on the
batstest suite was paused at the user's request to prioritize these bug fixes.PR created automatically by Jules for task 11190926747185957998