Skip to content
This repository was archived by the owner on Dec 10, 2024. It is now read-only.

Add: JLCPCB header picker#78

Draft
rubenbaldewsing wants to merge 6 commits into
mainfrom
feature/add_jlcpcb_header_picker
Draft

Add: JLCPCB header picker#78
rubenbaldewsing wants to merge 6 commits into
mainfrom
feature/add_jlcpcb_header_picker

Conversation

@rubenbaldewsing

@rubenbaldewsing rubenbaldewsing commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

Add: JLCPCB header picker

Description

Also fix indentation in LCSC.py picker

Checklist

Please read and execute the following:

  • My code follows the coding guidelines of this project
  • My PR title is following the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I ran Black to format my code

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct:

@rubenbaldewsing rubenbaldewsing self-assigned this Sep 25, 2024
@rubenbaldewsing
rubenbaldewsing marked this pull request as ready for review September 25, 2024 20:10
@rubenbaldewsing rubenbaldewsing added the enhancement New feature or request label Sep 25, 2024
Comment thread src/faebryk/libs/picker/lcsc.py
Comment thread src/faebryk/libs/picker/jlcpcb/picker_lib.py Outdated
Comment thread src/faebryk/libs/picker/jlcpcb/picker_lib.py Outdated
@rubenbaldewsing
rubenbaldewsing marked this pull request as draft September 25, 2024 20:30
@rubenbaldewsing

Copy link
Copy Markdown
Collaborator Author

Maybe @JasperZP or @iopapamanoglou can look at the test and new filter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants