fix: limit authz.MsgExec nesting depth in ante decorators and coredaos VetoProposal msg#344
Merged
Merged
Conversation
julienrbrt
approved these changes
Jun 22, 2026
Add tests for the nesting-depth cap introduced in the previous commit: - x/coredaos/types: direct unit tests for FlattenAnyMsgs covering flatten correctness and the depth boundary (8 accepted, 9 rejected). - ante: exercise the limit through ValidateVoteMsgs, asserting the inner vote is reached at the limit and that one layer beyond is rejected with the depth error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbounded nesting could be potentially abused to cause slowdowns. This PR limits nesting to a depth of 8 (arbitrary constants) in 2 places (constants kept separate for cleanliness) affecting the
GovSubmitProposalDecoratorandGovVoteDecoratorante decorators as well as thex/coredaosVetoProposalmessage.