fix: correct Wigner 3j argument order in reduced_dipole#1134
Merged
Conversation
Swap the m-arguments passed to wigner3j in reduced_dipole so the second triplet matches the intended (lf, li-lf, -li) ordering rather than (li, lf-li, -lf). Same fix as for ARTS 2.6 in PR atmtools#1133.
Fix will be done in separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect argument ordering in the Wigner 3j symbol computed inside
reduced_dipolewithin the Hartmann ECS line-shape model. The previous call swapped the(li, lf - li, -lf)triplet with(lf, li - lf, -li), producing wrong reduced dipole values and thus erroneous scaling of relaxation-matrix off-diagonal elements. The corrected arguments restore the physically intended coupling for the rotational quantum numbers.Same fix as in ARTS 2.6 PR #1133.
Changes
src/core/lbl/lbl_lineshape_voigt_ecs_hartmann.cpp: Updated both branches of theiseven(Jf + lf + 1)conditional inreduced_dipoleto callwigner3j(Jf, k, Ji, lf, li - lf, -li)instead ofwigner3j(Jf, k, Ji, li, lf - li, -lf), ensuring the bra-side and ket-side angular momentum couplings are passed in the correct order.Breaking Changes
None — this is a bug fix. Results previously computed with the Hartmann ECS line-shape model for affected transitions will change numerically to the correct values.