feat: Inbox タブ（Phase 1 — 一覧・プレビュー・保留提案の表示） - #95
Merged
Conversation
The vault's `inbox/` folder was invisible to the app: notes dropped there to file later could only be read in Obsidian, and when an unattended vault-tidy run could not decide where one belonged it parked the destination it proposed in `_ai/memory/tidy-pending.json` — a file nothing ever displayed. The judgement existed; it just had no way out. Add an Inbox tab that lists those notes with their age, previews them, and shows the parked proposal and its reason beneath the note it belongs to. It is read-only: filing still happens in Obsidian (a button jumps there), and acting on a proposal from inside workhub comes later. The listing lives in a new `inbox` module, and `tidy` now decides whether it has work by asking that module for the same list the tab shows. The exclusion rules (`README.md`, the configured hold folders) therefore exist once — a note the user can see in the tab is exactly a note tidy would consider — and `load_pending` moves there too, widened to read `reason` and `proposal`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The version behind ui/resizable.tsx takes `orientation`, percent-string sizes and per-panel ids, none of which match the shadcn examples — the mismatch surfaces as a misleading "Property 'direction' does not exist" typecheck error (hit while building the Inbox tab, T-0104). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
vault の
inbox/に置いたノートがアプリから見えず滞留していた問題に対して、Inbox タブを追加する（T-0104 / Phase 1）。あわせて、vault tidy が分類を保留したノートの「移動先候補と理由」を初めて画面に出す。tidy はこれまでも_ai/memory/tidy-pending.jsonに判断を書いていたが、それを表示する場所が無かった。設計: vault の
projects/workhub/dev-notes/Inbox - 受信ノート処理導線 設計.md変更内容
src-tauri/src/inbox.rs（新規） —inbox/の列挙、保留提案の読み取り、本文取得src-tauri/src/tidy.rs—stale_in_dirを削除し、has_stale_inboxをinbox::list_notesの上に書き直し。load_pendingはinbox.rsへ移動しreason/proposalも読むよう拡張src-tauri/src/commands.rs—list_inbox_notes/read_inbox_notesrc/components/inbox-view.tsx（新規）、src/app.tsx— Inbox タブ（Tasks の次）src/components/help-view.tsx— Inbox の節を追加.claude/rules/ui-conventions.md— resizable-panels の prop API を記録設計上の判断
除外ルールを 1 か所に集約した。 UI 用に
inbox/を走査するコードを別に足すと tidy 側の判定（README.md、Exclude folders）と二重になりいずれずれる。tidy が「作業があるか」を判断する際も同じinbox::list_notesを使うため、タブに見えるノート = tidy が対象にするノートが構造的に保証される。閾値と除外フォルダはコマンド側で設定から読む（フロントには渡さない）。ファイル監視は入れず、タブがアクティブになるたびに読み直す。
スコープ外（Phase 2 以降）
移動・archive・タスク化・「今すぐ ingest」・未処理件数バッジ。Phase 1 は読むだけで、ファイリングは従来どおり Obsidian で行う。
確認
cargo fmt --check/cargo clippy --release --all-targets -- -D warnings/cargo test --release（191 件）/npm run buildすべて通過README.mdと_wip/は一覧に出ない🤖 Generated with Claude Code