Skip to content

fix(quick-capture): keep save button visible with long descriptions - #94

Merged
atman-33 merged 2 commits into
mainfrom
fix/T-0102-quick-capture-layout
Jul 27, 2026
Merged

fix(quick-capture): keep save button visible with long descriptions#94
atman-33 merged 2 commits into
mainfrom
fix/T-0102-quick-capture-layout

Conversation

@atman-33

Copy link
Copy Markdown
Owner

Summary

  • The description textarea in the quick-capture window grew with its content (shared Textarea uses field-sizing-content), and its flex-item wrapper had no floor (min-height: auto) — long descriptions pushed the "Save to inbox" footer out of the window, where the container's overflow-hidden clipped it entirely.
  • Pinned the row with min-h-0 + field-sizing-fixed so the textarea fills the remaining space and scrolls internally instead, reusing the idiom already used by the maximized task-dialog editor.
  • Set min_inner_size(360, 260) on the quick-capture window so manual resizing can't hide the footer either.
  • Documented the fill-vs-grow Textarea idiom in .claude/rules/ui-conventions.md to prevent recurrence.

Related: T-0102

Test plan

  • npm run build (tsc + vite) passes; confirmed field-sizing-fixed{field-sizing:fixed} is emitted in the CSS the quick-capture window loads
  • cargo fmt --check clean
  • cargo clippy --all-targets -- -D warnings clean
  • cargo test --release — 185 passed
  • Manual: open quick capture, paste a long multi-line description, confirm the Save button stays visible and the textarea scrolls internally (not verified in this environment — the tauri dev window can't be driven headlessly here)

🤖 Generated with Claude Code

atman-33 and others added 2 commits July 28, 2026 00:52
The shared Textarea uses field-sizing-content, so the description grew with
its content. Its wrapper was a flex item with the default min-height: auto
and no resolvable height for h-full, so the row expanded past the window and
the container overflow clipped the footer holding "Save to inbox".

Pin the row with min-h-0 + field-sizing-fixed and scroll inside the textarea
instead, matching the idiom already used by the maximized task-dialog editor.
Also set a min inner size on the window so manual resizing cannot hide the
footer either.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c6ae80c-b0da-4da3-a3ce-d98e921eefdb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/T-0102-quick-capture-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@atman-33
atman-33 merged commit 61556d1 into main Jul 27, 2026
2 checks passed
@atman-33
atman-33 deleted the fix/T-0102-quick-capture-layout branch July 27, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant