fix(quick-capture): keep save button visible with long descriptions - #94
Merged
Conversation
The shared Textarea uses field-sizing-content, so the description grew with its content. Its wrapper was a flex item with the default min-height: auto and no resolvable height for h-full, so the row expanded past the window and the container overflow clipped the footer holding "Save to inbox". Pin the row with min-h-0 + field-sizing-fixed and scroll inside the textarea instead, matching the idiom already used by the maximized task-dialog editor. Also set a min inner size on the window so manual resizing cannot hide the footer either. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Textareausesfield-sizing-content), and its flex-item wrapper had no floor (min-height: auto) — long descriptions pushed the "Save to inbox" footer out of the window, where the container'soverflow-hiddenclipped it entirely.min-h-0+field-sizing-fixedso the textarea fills the remaining space and scrolls internally instead, reusing the idiom already used by the maximized task-dialog editor.min_inner_size(360, 260)on the quick-capture window so manual resizing can't hide the footer either..claude/rules/ui-conventions.mdto prevent recurrence.Related: T-0102
Test plan
npm run build(tsc + vite) passes; confirmedfield-sizing-fixed{field-sizing:fixed}is emitted in the CSS the quick-capture window loadscargo fmt --checkcleancargo clippy --all-targets -- -D warningscleancargo test --release— 185 passedtauri devwindow can't be driven headlessly here)🤖 Generated with Claude Code