prep codebase for addition of integration tests#144
Merged
Conversation
Signed-off-by: Alex Price <aprice@atlassian.com>
awprice
requested review from
MinyiZ,
castlemilk,
mwhittington21 and
vincentportella
mwhittington21
approved these changes
May 19, 2026
MinyiZ
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep codebase for addition of integration tests
Preparatory refactor ahead of integration tests landing in a follow-up.
What
Optionsgain timing knobs. All hard-coded durationsin the CNR and CNS state machines (
scaleUpWait,requeueDuration, theinline
60s/30sliterals, etc.) move onto the existingOptionsstructs. Package-level
var/constblocks are removed; call sites readt.options.<Knob>.cmd/manager/main.goexposes them as kingpin flags. 10 new flags(
--cnr-scale-up-wait, …,--cns-draining-pods-requeue) with defaultsthat match the previously hard-coded values exactly. Bonus: operators
can now tune these without rebuilding.
NewGenericCloudProvidertakes interfaces, not concrete types.Switched to
autoscalingiface.AutoScalingAPI/ec2iface.EC2APIsotest code can wrap the existing fake with instrumented decorators.
Behaviour
Unchanged. Every flag default matches the value it replaced, and the only
signature change (
NewGenericCloudProvider) is satisfied by existingcallers.
Testing
go test ./pkg/... ./cmd/...passesgo build ./...clean