Polish explorer folder open, close, and collapse behavior#672
Conversation
755ae39 to
f7ccfde
Compare
mehmetozguldev
left a comment
There was a problem hiding this comment.
Thanks, the product direction here is good. Preserving nested folder state on normal close and separating explicit collapse behavior makes sense, and the terminal
paste warning setting is useful.
Before merging, please update this against current master and fix two issues:
-
The merged result currently fails typecheck because
TerminalusesButton variant="outline"andvariant="primary", but the current shared Button primitive only
supports the existing variants. Please align these call sites with the current Button API. -
The explorer row wrapper now defaults to
max-height: 24px, but comfortable density uses 28px rows and the CSS variable is only set during row animation. Please
make the row height stable for all densities so comfortable rows don’t get clipped.
Also worth making the new explicit collapse action reachable from keyboard or context menu, since it is now a distinct explorer action.
- keep regular folder close separate from destructive collapse so nested state restores when reopened - refine root row controls, sticky row actions, and folder motion so the tree behaves consistently while scrolling - keep the terminal paste warning flow local to the terminal with a persisted do-not-show-again setting
f7ccfde to
588094a
Compare
|
Addressed review. This branch is now rebased onto current master, the terminal paste dialog uses the current Button variants, file-tree row height is stable across densities instead of defaulting to 24px during non-animated rows, and the explicit collapse action is reachable from the context menu as well as the row action. |
What really changes
The file explorer now treats open, close, and collapse as three separate actions instead of blending them together. Normal open and close preserve the folder's previous nested state, while the collapse control intentionally resets the subtree and uses the stepped folder-only collapse animation.
The explorer controls are also more consistent at the workspace root and in sticky ancestor rows, and the terminal multiline paste warning now supports a do-not-show-again flow with a settings toggle to restore it.
Point by point
Implementation details