Add parallel get_fmap to pyat#1059
Open
oscarxblanco wants to merge 11 commits into
Open
Conversation
Contributor
Author
|
Dear all, who could review this P.R. ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all,
I have made an implementation of the frequency maps called
get_fmap.It speeds up the calculation by a factor 2 in the cases I tried with at.MPMode.CPU. Instead of tracking particles in blocks that could only be reused when all particles are done, it uses every CPU to track an individual particle, and extract the frequency and frequency variation, signaling when it is done in order to immediately track the next.
Memory handling is very conservative as there is no need to keep all information from tracking until the frequency is analyzed, but, if the users prefers to set limits on max memory or minimum free memory in the system it could be set. This memory handling is done through
psutilwhich would need to be installed but it is not a general requirement because the method works well without it.It also extends the functionality to do other planes, e.g.$\delta$ -x, and the output is now a dictionary containing the axis names. Axes indexes (0 to 5) are also store in the dictionary.
There is also the possibility to calculate the tune variation with a moving window which should highlight smaller differences. See for example D. Shatilov, E. Levichev, E. Simonov and M. Zobov https://journals.aps.org/prab/abstract/10.1103/PhysRevSTAB.14.014001.
In addition, we keep the number of turns the particle survived which is a complementary information of particle motion in the area beyond the boundary of stable motion. It could show if unstable particles are lost rapidly or slowly.
Any (6,n) array of particles could be provided using the argument 'particles', otherwise, the arguments 'window', 'axes' and 'grid_size' will create a rectangular 2D array for the user.
Unfortunately at.MPMode.GPU is not yet implemented.